Merge linting phases #18735
Closed
Merge linting phases #18735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-rd
force-pushed
the
merge-linting-phases
branch
from
b6bcbf0 to
61fa799
Compare
szymon-rd
force-pushed
the
merge-linting-phases
branch
from
61fa799 to
2d182de
Compare
|
We were wondering if these two phases could be merged during yesterday's spree. Digging further I found the original comments describing why they are not: #17622 (comment) and #17622 (comment), and this PR. I see that only community build C failed. Would you happen to remember why @szymon-rd? Otherwise, should I try to rebase and re-run the CI? |
|
Ah, mega cool, thanks! Let's close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18708