Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce libexec folder in the distribution #21427

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

hamzaremmal
Copy link
Member

As of now, when installing scala and adding the /bin directory to PATH, the common, cli-common-platform and common-shared scripts are also added. This PR moves the following script to the libexec folder to avoid the addition of the scripts.

Copy link
Contributor

@natsukagami natsukagami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (if it works)

@hamzaremmal hamzaremmal enabled auto-merge August 23, 2024 16:11
@hamzaremmal hamzaremmal merged commit b583664 into scala:main Aug 23, 2024
26 checks passed
@hamzaremmal hamzaremmal deleted the libexec branch August 23, 2024 16:44
@WojciechMazur
Copy link
Contributor

This change should not be backported to 3.5.2, am I right?

@hamzaremmal
Copy link
Member Author

Technically we can but I think it's best if we keep the same folder layout for the 3.5.x releases

hamzaremmal added a commit that referenced this pull request Dec 11, 2024
update scala-cli.jar path ref per
#21427

seeing some test failure in
Homebrew/homebrew-core#200691

```
Error: Unable to access jarfile /opt/homebrew/Cellar/scala/3.6.2/libexec/bin/scala-cli.jar
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants