Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude flaky fs2 tests from community-build #21912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Exclude flaky fs2 tests from community-build #21912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,13 @@ object projects:

lazy val fs2 = SbtCommunityProject(
project = "fs2",
sbtTestCommand = "coreJVM/test; coreJS/test", // io/test requires JDK9+
sbtTestCommand = List(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a quick workaround but maybe we could try to do a little better and attempt to bump fs2 version first and see if this got fixed on their side? Our managed community build seems to be using a version from two years ago.
And it looks like in the newest version of fs2 was moved from jvm and js to shared. So if we only patch it here, this will have no effect if we bump fs2 version later at some point in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but I'm afraid I don't have write access to dotty-staging/fs2 so cannot sync it with the upstream repo. @hamzaremmal would you be able to do it and update the submodule in this project?

Overall the issue seems to be rare (we know only about a single failure), so we might delay suppressing failing test for some more time now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @mpilquist

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WojciechMazur I will update dotty-staging/fs2 over the weekend

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotty-staging/fs2 is now in sync with the upstream and #21921 is updating the submodule in this repository.

// Exclude flaky tests
"""set core.jvm / Test / managedSources ~= { _.filterNot(_.getName == "BracketSuite.scala") }""",
"""set core.js / Test / managedSources ~= { _.filterNot(_.getName == "BracketSuite.scala") }""",
"coreJVM/test", // io/test requires JDK9+
"coreJS/test"
).mkString("; "),
sbtPublishCommand = "coreJVM/publishLocal; coreJS/publishLocal",
scalacOptions = SbtCommunityProject.scalacOptions.filter(_ != "-Wsafe-init"),
dependencies = List(cats, catsEffect3, munitCatsEffect, scalacheckEffect, scodecBits)
Expand Down
Loading