Bring back the fix for scaladoc TastyInspector regressions #21929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings back the previosuly reverted commit with an added fix for the test.
Florian3k
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test_windows_full]
Brings back the previously reverted commit with an added fix for the failing test on windows. The "fix" is a bit disappointing - we revert one of the changes to getScalaLibraryPath() which was initially added to also combat similar failures on windows, after ... also having to revert from main (in #17751). It really does seem like that previous fix should keep working, as it only changes the letter cases of the
scala-library-2path onto the correct one. For some unclear reason, whether or not we reuse the compiler context from scaladoc in the tasty inspector forces the case lettering to be either correct from the perspective of the file system or incorrect (but contained in thejava.class.pathproperty). Nevertheless, with an impending end of the current release cycle, I am slowly running out of time to properly investigate that, so I added a comment in the related part of the code.Closes #21743
Closes #18231