Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove "One of these files" error #21975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Nov 19, 2024

Problem

Fixes #21973
Fixes #17394
Ref sbt/sbt#7726
Ref #7652

Currently the ambiguous symbol detection raises false positives when used together with -Wunused:imports. sbt 2.x plugins are running into this bug.

Solution

Remove the faulty ambiguous symbol detection for now.

**Problem**
See scalagh-21973. Currently the ambiguous symbol detection raises
false positives when used together with `-Wunused:imports`.

**Solution**
Remove the faulty ambiguous symbol detection for now.
@KacperFKorban
Copy link
Member

I think that we should fix the implementation of computeMembersNamed instead. It looks like all those issues are caused by some bug in that function.

@eed3si9n
Copy link
Member Author

#17394 has been open since May 2023, and I don't think anyone has sent a PR to fix it thus far. Wouldn't you agree that having no linter is better than a false-positive liner in a compiler for the current stable releases? (3.3.x, 3.5.x) While fixing forward would be ideal, every project has finite resource and priority list, so we should be ok with dropping bad linters.

This PR adds a test, so when the fix is implemented hopefully before the next minor series, it can come back as nightly first etc.

@dwijnand
Copy link
Member

Wouldn't you agree that having no linter is better than a false-positive liner in a compiler for the current stable releases? (3.3.x, 3.5.x)

I'd agree with you, on that basis, if the change were -Wunused:imports specific. But it's not, it's general to all SymDenotation#dropStale.

@KacperFKorban
Copy link
Member

I agree that it is not ideal to have an issue like this lay around for so long.
@Gedochao Should we assign someone to fix the underlying issue this cycle?

@eed3si9n
Copy link
Member Author

@dwijnand When there's an interference between feature A and feature B, I'm suggesting that we drop (revert PR when possible) either A or B, not A ∩ B, since likely the bug can pop up with some other intersection as well. But I guess it's case by case, since we can't just drop macro and extension methods when they interfere.

@Gedochao
Copy link
Contributor

I agree that it is not ideal to have an issue like this lay around for so long. @Gedochao Should we assign someone to fix the underlying issue this cycle?

Yup, we'll try to squeeze it into 3.6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants