Ignore pushes to branches prefixed with backport- in CI
#21989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
commented
Nov 20, 2024
| @@ -20,6 +20,7 @@ on: | |||
| - 'gh-readonly-queue/**' | |||
| - 'release-**' | |||
| - 'lts-**' | |||
| - 'backport-**' | |||
There was a problem hiding this comment.
@hamzaremmal actually, do we care about builds of branches other than main? Typically a branch has a corresponding PR and then running the CI for this PR should be enough, right?
There was a problem hiding this comment.
Depends. We do sometimes maintain feature branches (like we did cc-experiment)...
WojciechMazur
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to use a changed branch naming schema for backporting branches in backporting scripts to avoid problems with branch protection rules:
backport-lts-{pr_number}instead oflts-backport-{pr_number}.When backporting PRs in a batch we only want to run the build for the last PR in a batch. We don't care about builds for particular branches