Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Streamline tryNormalize with underlyingMatchType" to LTS #21990

Closed
wants to merge 9 commits into from
Closed

Backport "Streamline tryNormalize with underlyingMatchType" to LTS #21990

wants to merge 9 commits into from

Conversation

prolativ
Copy link
Contributor

Backports #20268 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

prolativ and others added 9 commits November 20, 2024 10:50
@prolativ
Drop normalization of applied match alias arguments
50fd96b 
Delay their normalization until it is needed.
Avoids overflows from infinite match types that did not need to normalize.
Also improves MatchTypeTraces as a side effect.

It appears to have been added to avoid some separate issue, which seems to have been fixed.
It is no longer needed since the previous fix with constant folding in disjointnessBoundary.

[Cherry-picked 32752e2][modified]
@prolativ
Use cached underlyingMatchType when normalizing applied match aliases
acaaeb3 
Also fixes underlyingMatchType to not use the resType of HKTypeLambdas
It should only be in `isMatch` used for `AliasingBounds`, not `isMatchAlias`

[Cherry-picked ac98023][modified]
@prolativ
Cache underlying applied compiletime.ops
cda1d40 
[Cherry-picked 68ca883][modified]
@EugeneFlesselle @prolativ
Use underlyingNormalizable in Type#tryNormalize
8621dc4 
[Cherry-picked a6cadec]
@EugeneFlesselle @prolativ
stripLazyRef for underlyingNormalizable
ea96161 
[Cherry-picked 4fbba66]
@EugeneFlesselle @prolativ
Drop handleRecursive from MatchType#tryNormalize
dc2d31b 
There is already a `handleRecursive` in `reduced`
Having the two makes error messages undeterministic, see #20269

[Cherry-picked 309b1cf]
@prolativ
Regroup tryNormalize logic
08967f6 
[Cherry-picked 0b87d7f][modified]
@prolativ
Add i974.scala to neg-best-effort-pickling.blacklist
1bc6fc8 
[Cherry-picked 9df3942][modified]
@EugeneFlesselle @prolativ
Add test for #20482
ad6eb2b 
tryNormalize used to not recursively check if tycon of applied type was normalizable,
this may be necessary in the case of an applied type dealiasing to a type lambda.

Fixes #20482

[Cherry-picked 9465d65]
@prolativ prolativ force-pushed the backport-lts-3.3-20268 branch from 0394d8f to ad6eb2b Compare November 20, 2024 16:39
@prolativ
Copy link
Contributor Author

Excluding 1bfa819 from the backport as it doesn't seem to be an integral part of the PR but rather an addition to #19871 which was not backported previously

@prolativ
Copy link
Contributor Author

This seems to break some tests. Rejecting the backport

@prolativ prolativ closed this Nov 20, 2024
@prolativ prolativ deleted the backport-lts-3.3-20268 branch November 20, 2024 18:02
@prolativ prolativ restored the backport-lts-3.3-20268 branch November 20, 2024 18:08
@prolativ prolativ deleted the backport-lts-3.3-20268 branch November 20, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prolativ @EugeneFlesselle