Expand value references to packages to their underlying package objects #22011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
added
needs-minor-release
odersky
force-pushed
the
add-package-object-values
branch
from
97fa8ff to
f6c6dfa
Compare
tgodzik
added
the
needs-sip
A package object can be seen as the facade of a package. For instance, it is the logical place where we want to write doc comments that explain a package. So far references to packages cannot be used as values. But if the package has a package object, it would make sense to allow the package reference with the meaning that it refers to this object. For instance, let's say we have ```scala package a object b ``` Of course, we can use `a.b` as a value. But if we change that to ```scala package a package object b ``` we can't anymore. This PR changes that so that we still allow a reference `a.b` as a value to mean the package object. Due to the way package objects are encoded the `a.b` reference expands to `a.b.package`.
odersky
force-pushed
the
add-package-object-values
branch
from
944425d to
4429fd1
Compare
odersky
added
stat:sip-in-progress
and removed
needs-sip
|
This is the experimental implementation of SIP 68 |
- Instead of "Dropped: package objects" have a new doc page "Toplevel Definitions" in "other new features". - Add a doc page for experimental reference-able package object, which uses some wording from the Pre-SIP.
odersky
force-pushed
the
add-package-object-values
branch
from
4429fd1 to
6e07688
Compare
smarter
approved these changes
Feb 18, 2025
| @@ -123,7 +123,6 @@ subsection: | |||
| - page: reference/dropped-features/type-projection.md | |||
| - page: reference/dropped-features/do-while.md | |||
| - page: reference/dropped-features/procedure-syntax.md | |||
| - page: reference/dropped-features/package-objects.md | |||
There was a problem hiding this comment.
This page will still show up in google search results, so eventually it will need to have a comment mentioning it's outdated pointing to the new doc.
|
@odersky is this out in any nightly version that people can try out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package object can be seen as the facade of a package. For instance, it is the logical place where we want to write doc comments that explain a package.
So far references to packages cannot be used as values. But if the package has a package object, it would make sense to allow the package reference with the meaning that it refers to this object. For instance, let's say we have
Of course, we can use
a.bas a value. But if we change that towe can't anymore. This PR changes that so that we still allow a reference
a.bas a value to mean the package object. Due to the way package objects are encoded thea.breference expands toa.b.package.