Update reference, MiMa previous version and sync TASTy version #22187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
WojciechMazur
commented
Dec 11, 2024
|
|
||
| // Tested only in nightly / release builds | ||
| // Protects from publishing artifacts with incorrect TASTY version | ||
| @Test def testReleasedTastyVersion(): Unit = { |
There was a problem hiding this comment.
This test actually would be never executed - RELEASEBUILD and NIGHTLYBUILD are set only for the release but not in tests executed as a requirement to start releasing job
…d before releasing artifacts
|
glad there's finally a real test :) |
hamzaremmal
reviewed
Jan 29, 2025
| @Test def testBuildTastyVersion(): Unit = { | ||
| val expectedVersion = sys.env.get(ExpectedTastyVersionEnvVar) | ||
| .getOrElse(fail(s"Env variable $ExpectedTastyVersionEnvVar not defined")) | ||
| .match { |
There was a problem hiding this comment.
Does this test even run? This is not valid syntax...
There was a problem hiding this comment.
foo.match {...} is a valid alternative syntax for foo match {...} in scala 3
There was a problem hiding this comment.
Then metals interpret the code as Scala 2 for some reason:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
28.7-experimental-1- it should have been set when branching of 3.6.3.Reference version and TASTy version bump needs to be performed at the same time (otherwise usage of compiler with stable TASTY would lead to failure in from-tasty non-bootstrapped tests)
[test_non_bootstrapped]