Append instead of prepending import selectors for the current scope when collecting them in CheckUnused #22314
Conversation
|
I have already marked this fixed by my PR, which rewrites the linting phase. |
|
@som-snytt If you can manage to get your PR into the next release, then I'll gladly close this one. Otherwise, merging this one now and replacing it with your rewrite won't hurt. |
|
@KacperFKorban no problem, just to avoid duplicate effort. The other PR has items to clean up before I ask someone to spend time on review. |
…hen collecting them in CheckUnused; Also make the wildcard selectors exclusion aware in CheckUnused
KacperFKorban
force-pushed
the
fix-i21420
branch
from
f08954c to
5000077
Compare
|
The funny thing is that the conflict makes rebasing a PR with many commits excessively painful. |
|
Ugh. I did not think you wanted to keep the history intact. In that case a "keep mine" resolution would have been enough. What you can do is start by reverting this commit on your branch, then rebase the rest. Then the rebase should be free, and at the end of the day you reintroduce the test case. |
|
Thanks, I'll try to improve my gitfu. I have the test case, of course. I tried to be open on my PR about what is to do. |
…hen collecting them in CheckUnused (scala#22314) Also make the wildcard selectors exclusion-aware in CheckUnused closes scala#21420
Also make the wildcard selectors exclusion-aware in CheckUnused
closes #21420