chore: do not assume scala types as transparent, source should enforce it #23105
+4
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natsukagami
approved these changes
May 6, 2025
natsukagami
reviewed
May 6, 2025
| def MatchableType: TypeRef = MatchableClass.typeRef | ||
| @tu lazy val AnyValClass: ClassSymbol = | ||
| val res = completeClass(enterCompleteClassSymbol(ScalaPackageClass, tpnme.AnyVal, Abstract, List(AnyType, MatchableType))) | ||
| val res = completeClass(enterCompleteClassSymbol(ScalaPackageClass, tpnme.AnyVal, Abstract | TransparentType, List(AnyType, MatchableType))) |
There was a problem hiding this comment.
Do we still need a separate definition for AnyValClass?
There was a problem hiding this comment.
Yes, Dotty is unable to compile AnyVal for now. It's in my todo list to attempt to make it compile AnyVal (if possible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #23104
This is done in a separate PR as both PRs only share the parent commit of 2012. Working on these kinds of changes in the future would be easier when #23099 is merged.