Update native config to support more configuration options #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still missing linktimeProperties, sourceLevelDebuggingConfig and semanticsConfig
|
I don't really get why mima is failing? |
Good question, and it seems to fail on an unapply. Maybe there is an optimization when there is more fields present? We might need to move it to a separate class? |
|
Running javap or a decompiler could shed a light on it |
|
The mima issue happens with when the case class has more than 22 fields so maybe some optimization that is happening. Anyway I grouped some things in to case classes and made sure we had < 22 fields so that we can add another case class with more stuff later if needed. Preferably we can look at a 3.0 release somewhere down the line where we clean up everything. |
I reduced the amount of fields by grouping some things in case classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still missing linktimeProperties, sourceLevelDebuggingConfig and semanticsConfig
These properties are missing because I don't really understand them and when I looked at how mill handles linking they don't include these options...
I added @unroll nativeLinkerReleaseMode: Option[NativeLinkerReleaseMode] = None, as a way to preserve bincompat for LinkerMode. In bloop I configured it to default to release-fast if None and LinkerMode being Release. This also means than linking JS and Native still are similar.
Clients can override the linkermode for SN by setting the mode in NativeLinkerReleaseMode. I figure this is a good compromise for now.