improvement: avoid atomic double touch if not needed

scalameta · Nov 21, 2024 · 8e5006f · 8e5006f
1 parent 29c783a
commit 8e5006f
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/metals/src/main/scala/scala/meta/internal/metals/ChosenBuildTool.scala b/metals/src/main/scala/scala/meta/internal/metals/ChosenBuildTool.scala
@@ -13,21 +13,23 @@ class ChosenBuildTool(conn: () => Connection) {
     )
 
   def selectedBuildTool(): Option[String] = {
-    val selected = currentTool
-      .get()
-      .orElse(
-        conn()
+    currentTool.get() match {
+      case selected @ Some(_) =>
+        selected
+      case None =>
+        val selected = conn()
           .query(
             "select * from chosen_build_tool LIMIT 1;"
           )(_ => ()) { _.getString("build_tool") }
           .headOption
-      )
-    selected.flatMap(toolName =>
-      currentTool.updateAndGet {
-        case None => Some(toolName)
-        case some => some
-      }
-    )
+
+        selected.flatMap(toolName =>
+          currentTool.updateAndGet {
+            case None => Some(toolName)
+            case some => some
+          }
+        )
+    }
   }
 
   def chooseBuildTool(buildTool: String): Int = synchronized {