Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emacs support table #5131

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Update emacs support table #5131

merged 1 commit into from
Apr 7, 2023

Conversation

kurnevsky
Copy link
Contributor

  • worksheets with decoration protocol are fully supported
  • lsp-metals supports quite a lot of metals extensions
  • source file analyzer commands are supported

@kurnevsky
Copy link
Contributor Author

kurnevsky commented Apr 6, 2023

btw, how metals is installed in vim? I wonder if I should change emacs to single click because it can be installed automatically if lsp-metals is present :)

@tgodzik
Copy link
Contributor

tgodzik commented Apr 6, 2023

btw, how metals is installed in vim? I wonder if I should change emacs to single click because it can be installed automatically if lsp-metals is present :)

I think via coursier, but most likely @ckipp01 can correct me.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kurnevsky
Copy link
Contributor Author

Well, emacs can install metals via coursier as well :)

@tgodzik
Copy link
Contributor

tgodzik commented Apr 6, 2023

Well, emacs can install metals via coursier as well :)

Hmm... actually vim might also be doing that without a need to provide a bootstraped binary. By all means if it only needs lsp-metals then I would say it's "one click" installation

- worksheets with decoration protocol are fully supported
- lsp-metals supports quite a lot of metals extensions
- source file analyzer commands are supported
- metals can be installed automatically via coursier
@kurnevsky
Copy link
Contributor Author

ok, changed that line. It might not always work, though, because we rely on automatically downloaded binaries. I'm not sure how it works for apple M1 (probably it emulates x86 automatically?), but for nix/guix these binaries don't work. Not sure, maybe we should change it to jars...

@ckipp01
Copy link
Member

ckipp01 commented Apr 6, 2023

I think via coursier, but most likely @ckipp01 can correct me.

Yup, under the hood it just uses coursier to bootstrap everything.

@tgodzik tgodzik merged commit 59c7956 into scalameta:main Apr 7, 2023
@kurnevsky kurnevsky deleted the emacs branch April 7, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants