feature: collect overridden symbols in Scala toplevel mtags #5607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
index-overridden
branch
from
7bb2fb1 to
c00f0d3
Compare
kasiaMarek
force-pushed
the
index-overridden
branch
from
c00f0d3 to
488efe5
Compare
tgodzik
reviewed
Sep 4, 2023
| input: Input.VirtualFile, | ||
| dialect: Dialect, | ||
| includeMembers: Boolean = true | ||
| )(implicit rc: ReportContext = EmptyReportContext): TextDocument = { | ||
| )(implicit rc: ReportContext = EmptyReportContext): EnrichedTextDocument = { |
There was a problem hiding this comment.
Perfect place for union types :( need to migrate faster to Scala 3 :D
| def language: Language | ||
| def indexRoot(): Unit | ||
| def input: Input.VirtualFile | ||
| def index(): s.TextDocument = { | ||
| protected def documentToResult(doc: s.TextDocument): T | ||
| def index(): T = { |
There was a problem hiding this comment.
Would it make sense to just have overrides accessible as separate method? Do we need to box it together with TextDocument?
Comment on lines
+418
to
+419
| expectTemplate.map(tmpl => | ||
| withOwner(tmpl.owner) { |
There was a problem hiding this comment.
Do we need owner here? Since we only save those by name?
|
Closing this as a part of: #5623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.