improvement: add timeout to fix java version for sbt request #5715
Conversation
kasiaMarek
force-pushed
the
timeout-fix-java-version-request
branch
from
d85707f to
52138d0
Compare
| @@ -206,6 +208,8 @@ case class SbtBuildTool( | |||
| shutdownBspServer(shellRunner).ignoreValue | |||
| case _ => Future.successful(()) | |||
| } | |||
| .withTimeout(10, TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
IS this the timeout of message requests in VS Code?
There was a problem hiding this comment.
More like 15sec. But I also realised that this wasn't very smart, since if you'd press the restart button after the timeout (which you always can do) it would simply shut down the sbt server. I fixed that now.
| .asScala | ||
| .flatMap { | ||
| case Messages.SbtServerJavaHomeUpdate.restart => | ||
| if (promise.isCompleted) restartSbtBuildServer() |
There was a problem hiding this comment.
completing the promise will only happen after this future is finished, so this condition will always be false, no?
There was a problem hiding this comment.
No, I don't think you're right. The promise is completed by (...).withTimeout(...), so a new future with await inside. The original Future, won't get cancelled, 'cause you can't cancel futures in Scala, so this is the code that will be executed when the user chooses restart after the timeout. (Which you can do in VSCode, 'cause the notifications are stored.) Am I wrong?
There was a problem hiding this comment.
yes, you're right. I didn't think about the after 15 seconds part. Might be good to add some comments, since it doesn't seem easy to follow.
| .asScala | ||
| .flatMap { | ||
| case Messages.SbtServerJavaHomeUpdate.restart => | ||
| if (promise.isCompleted) restartSbtBuildServer() |
There was a problem hiding this comment.
yes, you're right. I didn't think about the after 15 seconds part. Might be good to add some comments, since it doesn't seem easy to follow.
kasiaMarek
force-pushed
the
timeout-fix-java-version-request
branch
from
b4c86be to
6ff50be
Compare
No description provided.