Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix completions tests after a new artifact starting with io.circ showed up #5723

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Oct 6, 2023

This shouldn't happen too often.

@tgodzik tgodzik requested a review from jkciesluk October 6, 2023 08:32
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! Looks like the change is also needed in CompletionScalaCliSuite

…irc showed up

This shouldn't happen too often.
@tgodzik tgodzik force-pushed the fix-completions-tests branch from 4b59d7c to 7fb5c1b Compare October 6, 2023 10:00
@tgodzik
Copy link
Contributor Author

tgodzik commented Oct 6, 2023

Thanks for fixing that! Looks like the change is also needed in CompletionScalaCliSuite

Ach, my bad! I missed that one

@tgodzik tgodzik merged commit e22f1b4 into scalameta:main Oct 6, 2023
@tgodzik tgodzik deleted the fix-completions-tests branch October 6, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants