improvement: fetch missing dependency sources #5819
Conversation
kasiaMarek
force-pushed
the
fetch-deps-sources
branch
2 times, most recently
from
1955642 to
0610210
Compare
kasiaMarek
force-pushed
the
fetch-deps-sources
branch
from
0610210 to
7062b8c
Compare
kasiaMarek
force-pushed
the
fetch-deps-sources
branch
from
223f168 to
6c67b4b
Compare
metals/src/main/scala/scala/meta/internal/metals/JarSourcesProvider.scala
Outdated
Show resolved
Hide resolved
| .when(groupId.nonEmpty && version.nonEmpty && artifactId.nonEmpty) { | ||
| Dependency.of(groupId, artifactId, version) | ||
| } | ||
| .filterNot(dep => isSbtDap(dep) || isMetalsPlugin(dep)) |
There was a problem hiding this comment.
Should we filter those out? This might be added manually to the build even by the user. There is no way to see if it was added on purpose or automatically. I think it's fine to leave it.
There was a problem hiding this comment.
I can't get sbt-debug-adapter to resolve correctly.
| private def fetchDependencySources( | ||
| dependency: Dependency | ||
| ): List[Path] = { | ||
| Fetch |
There was a problem hiding this comment.
Forgot about it and I think we do it wrong in most places. Could we make sure we handle an issue if there is no internet available? Make sure it doesn't get stuck etc. Probably we should have some timeout and do it in a separate future
try resolving debug adapter plugin
kasiaMarek
force-pushed
the
fetch-deps-sources
branch
from
c02e2c6 to
2c3950f
Compare
| .addClassifiers(Classifier.sources) | ||
| .future() | ||
| .map(_.map(_.toPath()).toList) | ||
| .withTimeout(5, TimeUnit.MINUTES) |
There was a problem hiding this comment.
| .withTimeout(5, TimeUnit.MINUTES) | |
| .withTimeout(1, TimeUnit.MINUTES) |
would be enough I think
There was a problem hiding this comment.
I wonder if could fail quickly if maven central is not available?
metals/src/main/scala/scala/meta/internal/metals/JarSourcesProvider.scala
Show resolved
Hide resolved
When build server fails to provide dependency sources for a build target metals will try to resolve/download the missing sources.
resolves: #4780