improvement: Send error back to client to show #5853
Conversation
|
@ckipp01 what do you think, should we keep displaying the error message? via the standard showMessage mechanism? |
Yea I think maybe this might be best? I think each of the clients that are doing any DAP related stuff will have an extension that can probably handle this in an appropriate way for that client. |
Previously, it would be very difficult to show a proper error message to the user. Especially in VS Code a generic message was show, which was very confusing for users. Now, we send the error message in the response so that the client can handle it as they want. I wonder if we should keep displaying the message, but not sure if it's not better to just change the clients here to show the error.
tgodzik
force-pushed
the
improve-errors
branch
from
9338a6e to
686fe66
Compare
|
My 2 cents: could we still retain the message sent through the standard LSP (maybe as an option or in addition to the custom one)? 🙂 The reason I ask is that the more bespoke solutions like that are used, the more they require support and maintenance in all the clients. Scala is not as popular as some other languages (think for example Python, Rust, Go) and as a result it often doesn't get first-class support out of the box. The community has limited manpower to add and update special handling. While VSCode and Neovim do get great support from you (big thanks to everyone involved and to @ckipp01 for his awesome Neovim plugin!) there are other editors which do not (like Helix, Emacs and many others, including Fleet and maybe even IntelliJ in the future). I believe the more common protocol is used the better it is for the overall user experience. No need to proliferate plugins, duplicate work or custom configuration. 🙂 Perhaps sending a message to the user is a basic enough action that we could employ the LSP integration here. Sorry for the long message or if I misunderstood the proposed approach. 🙂 |
|
@filipwiech thinking it over I realized we can rely on lsp4j's own exception, which will be sent properly to the client (so using normal LSP mechanisms). Did another PR since it's totally different #5864 It might need to fixes to tests, but looks to be working pretty well. |
Previously, it would be very difficult to show a proper error message to the user. Especially in VS Code a generic message was show, which was very confusing for users.
Now, we send the error message in the response so that the client can handle it as they want.
I wonder if we should keep displaying the message, but not sure if it's not better to just change the clients here to show the error.
Related to scalameta/metals-vscode#1438