improvement: Remove semantic tokens fallback #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
force-pushed
the
rem-sem-fallback
branch
from
8606fe3 to
a438ca1
Compare
jkciesluk
force-pushed
the
rem-sem-fallback
branch
from
a438ca1 to
e78e98e
Compare
kasiaMarek
reviewed
Jan 4, 2024
| @@ -171,7 +171,7 @@ class SemanticTokensLspSuite extends BaseLspSuite("SemanticTokens") { | |||
| "self-type", | |||
| """|<<package>>/*keyword*/ <<a>>/*namespace*/ | |||
| | | |||
| |<<object>>/*keyword*/ <<Abc>>/*class*/ { <<self>>/*variable,readonly*/: <<Any>>/*class*/ <<=>>>/*operator*/ | |||
| |<<object>>/*keyword*/ <<Abc>>/*class*/ { self: Any <<=>>>/*operator*/ | |||
There was a problem hiding this comment.
I feel like Any should be marked as class here.
There was a problem hiding this comment.
Looks like no features work on Any (actually its not specific to Any, but I haven't yet figured the pattern) in self type, including hover and document highlight, because there is no symbol at this node in the AST.
I think its best to work on it in a follow up, since its not specifically related to semantic highlighting. I would still be coloured as class by the editor
There was a problem hiding this comment.
It seems to work with the self type in line 192, so I though it's a strictly Any/AnyRef type of situation. Anyway let's do it as a follow up .
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for identifiers with no symbol found, we've added fallback semantic tokens based on simple heuristic.
This was causing some problems for not-compiling projects, probably best to remove it and leave syntax highlighting to an editor.