chore: Add more information about classpath and compiler options when severe error happens #5986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
add-more-data
branch
from
a541c03 to
76f047d
Compare
kasiaMarek
approved these changes
Jan 2, 2024
| )(implicit ec: ExecutionContextExecutor, rc: ReportContext) { | ||
|
|
||
| def this( |
There was a problem hiding this comment.
Is there a difference between this and giving a default value to the additionalReportingData arg?
There was a problem hiding this comment.
It seems there is for the JVM, it fails in with the default argument.
| @@ -64,6 +64,12 @@ case class ScalaPresentationCompiler( | |||
| config, | |||
| sh, | |||
| () => new Scala3CompilerWrapper(newDriver), | |||
| () => s"""|Scala version: $scalaVersion | |||
| |Classpath: | |||
| |${classpath.mkString(", ")} | |||
There was a problem hiding this comment.
Don't you want to have that missing, exists info for classpath here too?
… severe error happens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5272