bugfix: Add name field to distinguish different action data #6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
fix-gson-issues
branch
from
d7ed28d to
0aa3b13
Compare
Also refactor another code action to detect possible conflicts I was hoping to have it cleaner, but using a stable id between codeAction request and resolve one is safest. I also check if everything is not null, so we should be safe even if someone forgets to set the name properly.
tgodzik
force-pushed
the
fix-gson-issues
branch
from
0aa3b13 to
6d2d068
Compare
tgodzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.