bugfix: Publish native interfaces with full suffix #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scalameta#4571 crossVersion actually is set differently if you use `crossProject` so if you disable it you get no suffix in all platforms.
kitbellew
approved these changes
Nov 20, 2024
| @@ -85,8 +85,6 @@ lazy val interfaces = crossProject(JVMPlatform, NativePlatform) | |||
| moduleName := "scalafmt-interfaces", | |||
| description := | |||
| "Dependency-free, pure Java public interfaces to integrate with Scalafmt through a build tool or editor plugin.", | |||
| crossVersion := CrossVersion.disabled, | |||
| autoScalaLibrary := false, | |||
There was a problem hiding this comment.
what does this do? not needed for native, then?
There was a problem hiding this comment.
So it doesn't add Scala library for Java artifacts, since it will not be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4571
crossVersion actually is set differently if you use
crossProjectso if you disable it you get no suffix in all platforms.