[scalardl-ledger] Support TLS in ScalarDL Ledger chart #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kota2and3kan
requested review from
superbrothers,
choplin,
feeblefakie,
supl and
jnmt
kota2and3kan
changed the title
kota2and3kan
force-pushed
the
support-tls-scalardl-ledger
branch
from
b4038b8 to
29a58b1
Compare
feeblefakie
approved these changes
Mar 21, 2024
| {{- if .Values.ledger.tls.caRootCertSecret }} | ||
| - -tls-ca-cert=/tls/certs/ca-root-cert.pem | ||
| {{- end }} | ||
| - -tls-server-name={{ .Values.ledger.tls.overrideAuthority }} |
There was a problem hiding this comment.
Ditto. (The same question as the ScalarDB Cluster PR.)
There was a problem hiding this comment.
Thank you for your review!
I answered it on the ScalarDB Cluster PR side.
#255 (comment)
jnmt
approved these changes
Mar 25, 2024
|
@jnmt
Thank you for pointing it out! I found the root cause. The cause of CI failure is the issue on the CI side... We use the bitnami helm chart to deploy PostgreSQL as a backend DB in the CI. However, recently they released a new major version and we faced an error by the backward-incompatible things. So, I fixed in in the following PR. 🙂 |
@kota2and3kan Thank you! Got it : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds TLS support in the ScalarDL Ledger chart.
In this update, users can configure TLS features and set key/cert files for ScalarDL Ledger.
Note: You need to enable the wire encryption feature on the ScalarDL Ledger side by setting
scalar.dl.ledger.server.tls.enabled=truein theledger.ledgerPropertiesin your custom values file.[Client] ---> [Envoy] ---(TLS)---> [ScalarDL Ledger]Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
Support TLS configuration in the ScalarDL Ledger chart. You can enable TLS between Envoy and ScalarDL Ledger.