Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scalar-admin-for-kubernetes] Support TLS in Scalar Admin for Kubernetes chart #260

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

kota2and3kan
Copy link
Collaborator

@kota2and3kan kota2and3kan commented Apr 5, 2024

Description

This PR adds TLS support in the Scalar Admin for Kubernetes chart.

In this update, users can mount a root CA certificate on the pod of Scalar Admin for Kubernetes.

Then, users can specify the root CA certificate by using the --ca-root-cert-path option and run a pause request with TLS as follows.

[Scalar Admin for Kubernetes] ---> (TLS)---> [ScalarDB Cluster / ScalarDL]

Related issues and/or PRs

Changes made

  • Add new values to specify the name of the secret resource including root CA certificate.
  • Mount root CA certificate file on Pod to use TLS connections between Scalar Admin for Kubernetes and ScalarDB Cluster/ScalarDL.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Support TLS configuration in the Scalar Admin for Kubernetes chart. You can run a pause request with TLS.

Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one minor suggestion. Other than that, LGTM. Thank you!🙇🏻‍♂️

charts/scalar-admin-for-kubernetes/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@supl supl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you!

Copy link

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link

@choplin choplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 0f6fa9c into main Apr 12, 2024
13 of 14 checks passed
@feeblefakie feeblefakie deleted the support-tls-scalar-admin-for-kubernetes branch April 12, 2024 01:50
kota2and3kan added a commit that referenced this pull request Jul 3, 2024
…tes chart (#260)

* [scalar-admin-for-kubernetes] Support TLS in Scalar Admin for Kubernetes chart

* Update description

* Apply suggestions from code review

Co-authored-by: Josh Wong <[email protected]>

* Update values.yaml

---------

Co-authored-by: Josh Wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants