Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scalar-admin-for-kubernetes] Fix typo in README #261

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[scalar-admin-for-kubernetes] Fix typo in README #261

merged 1 commit into from
Apr 16, 2024

Conversation

kota2and3kan
Copy link
Collaborator

Description

This PR fix typo.

It's a very minor thing, but this typo (difference between values.yaml comment and README) cause the CI error.
https://github.com/scalar-labs/helm-charts/actions/runs/8655786113/job/23735277413

So, we have to fix it to run the CI properly.

Please take a look!

Related issues and/or PRs

Changes made

  • Fix typo and keep consistency between values.yaml and README.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@kota2and3kan kota2and3kan self-assigned this Apr 12, 2024
supl
supl approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@supl supl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you!

feeblefakie
feeblefakie approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 5382b70 into main Apr 16, 2024
14 checks passed
@feeblefakie feeblefakie deleted the fix-typo-README-scalar-admin-for-kubernetes branch April 16, 2024 08:04
kota2and3kan added a commit that referenced this pull request Jul 3, 2024
@kota2and3kan
[scalar-admin-for-kubernetes] Fix typo in README (#261)
91215df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supl supl supl approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@kota2and3kan kota2and3kan

Labels
bugfix scalar admin for kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kota2and3kan @feeblefakie @supl