Refactoring helm charts validation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tei-k
force-pushed
the
refactoring-helm-charts-validation
branch
from
66affb3 to
fc358bd
Compare
tei-k
force-pushed
the
refactoring-helm-charts-validation
branch
from
fc358bd to
cbde47f
Compare
tei-k
force-pushed
the
refactoring-helm-charts-validation
branch
from
6ca2b2f to
c6cff3f
Compare
tei-k
force-pushed
the
refactoring-helm-charts-validation
branch
from
d04538f to
f62d17e
Compare
superbrothers
previously approved these changes
May 16, 2021
feeblefakie
previously approved these changes
May 17, 2021
| strategy: | ||
| matrix: | ||
| k8s: | ||
| - v1.15.7 | ||
| - v1.16.4 | ||
| - v1.19.7 |
There was a problem hiding this comment.
I think it should be tested with multiple supported versions. But we haven't decided what versions to support. So, let's discuss and update.
There was a problem hiding this comment.
Updated k8s version in d9385c0, but can't find latest image.
There was a problem hiding this comment.
The latest image (v1.21.x) was provided 2 days ago.
tei-k
force-pushed
the
refactoring-helm-charts-validation
branch
from
00d868d to
d9385c0
Compare
|
@ymorimo @superbrothers The approvals are dismissed due to a minor change in the versions to test, but it is mostly unchanged. So, I will merge it. Please take a look quickly when you get another chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://scalar-labs.atlassian.net/browse/DLT-8981
Done
v1.19.7for ci test. (Delete oldv1.15.11andv1.16.9)helm/kind-actionandhelm/chart-testing-action.Remark
kubevaljust support v1.18.1