Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #16

Closed
wants to merge 12 commits into from
Closed

Conversation

lotusnoir
Copy link
Contributor

adding new features for S3 buckets

Copy link
Member

@benoit-garcia benoit-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for your contribution!
There's a few things that could be improved before merging, I made some suggestions.
Let me know if I can help with them.

README.md Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
benoit-garcia and others added 5 commits May 20, 2023 11:53
Co-authored-by: Benoit Garcia <[email protected]>
Signed-off-by: Philippe LEAL <[email protected]>
Co-authored-by: Benoit Garcia <[email protected]>
Signed-off-by: Philippe LEAL <[email protected]>
Co-authored-by: Benoit Garcia <[email protected]>
Signed-off-by: Philippe LEAL <[email protected]>
Co-authored-by: Benoit Garcia <[email protected]>
Signed-off-by: Philippe LEAL <[email protected]>
@lotusnoir lotusnoir closed this May 24, 2023
@lotusnoir lotusnoir reopened this May 24, 2023
@jgalais
Copy link
Contributor

jgalais commented Mar 28, 2024

Hello,

Thank you @lotusnoir and @benoit-garcia for your job.

@benoit-garcia Can you validate this Pull request ?

I want to create S3 bucket but tag usage it's an important thing.
I try to avoid to fork all Scaleway module to avoid to recreate the wheel each time.

Regards,

@benoit-garcia
Copy link
Member

Hello,

@jgalais
I've added support of tags on v2.0.0. Feel free to test and let me know.

@lotusnoir
Thanks for you work. I'd like to maintain some consistency on code style.
As I couldn't edit your pull request, I create #34 based on your code and improved/cleaned it a little.
Hope you won't mind; your contributions are highly appreciated.

@jgalais
Copy link
Contributor

jgalais commented Apr 2, 2024

Hello,

I tested this morning and tags function is ok.

Thank you.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants