Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.4 support #4

Closed
wants to merge 4 commits into from
Closed

Add python 3.4 support #4

wants to merge 4 commits into from

Conversation

EvaSDK
Copy link
Contributor

@EvaSDK EvaSDK commented Dec 26, 2014

Branch for review, please do not click merge from the WebUI.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.08%) when pulling 63b804c on python-34-support into 5f77110 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.08%) when pulling bd6b89f on python-34-support into 5f77110 on develop.

@EvaSDK
Copy link
Contributor Author

EvaSDK commented Dec 26, 2014

Also, it needs may need a patch in slumber to properly decode json data which is received as bytes in python 3.4 case.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6f45fd3 on python-34-support into 5f77110 on develop.

@EvaSDK
Copy link
Contributor Author

EvaSDK commented Dec 29, 2014

Relates to samgiles/slumber#58

@moul moul added the ideas label Apr 1, 2015
@brmzkw brmzkw force-pushed the develop branch 6 times, most recently from fec86bd to 814d70d Compare April 7, 2015 14:04
@EvaSDK
Copy link
Contributor Author

EvaSDK commented Oct 2, 2015

Closing as there seems to be no interest in this and I have moved to other things.

@EvaSDK EvaSDK closed this Oct 2, 2015
@moul moul removed the ideas label Oct 2, 2015
@brmzkw brmzkw reopened this Oct 7, 2015
@brmzkw
Copy link
Contributor

brmzkw commented Oct 7, 2015

Sorry, I missed this pull request. I'll work to merge it to master asap.

@kdeldycke
Copy link
Contributor

@moul can you check GitHub integration with Travis ? Looks like the project is still attached to its old URL (https://travis-ci.org/online-labs/ocs-sdk/), hence the failing tests.

@moul
Copy link
Contributor

moul commented Oct 7, 2015

Yep sure

@moul
Copy link
Contributor

moul commented Oct 7, 2015

The migration seems to be taken into account by travis, see: https://travis-ci.org/scaleway/python-scaleway/builds

This PR is older than the migration, can you try to git push a dummy commit then git push -f HEAD~1 to trigger a new build ?

@kdeldycke
Copy link
Contributor

@moul ah yes. Everything's fine then. We'll just wait for @brmzkw to resume work on this PR for Travis to pick-up the pending work. No need to rush things out.

@brmzkw brmzkw closed this in 2b476cf Oct 12, 2015
@moul moul removed the in progress label Oct 12, 2015
@brmzkw brmzkw deleted the python-34-support branch October 12, 2015 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants