rfctr: add type annotations #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves packaging reliability because it prevents tests from running against the current directory instead of the installed version of the package.
scanny
force-pushed
the
scanny/add-type-annotations
branch
4 times, most recently
from
c6a49f3
to
ceb8472
Compare
- Add `pyproject.toml` and gather configuration there. Move `.ruff.toml` contents into `pyproject.toml`. - Add `requirements-test.txt`.
scanny
force-pushed
the
scanny/add-type-annotations
branch
4 times, most recently
from
ac2b1bc
to
a437950
Compare
Add type-annotations broadly, but prioritizing interface objects and methods. Adjust text-width to 100, remove Python 2 support, etc.
scanny
force-pushed
the
scanny/add-type-annotations
branch
from
a437950
to
f39394b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add many type annotations. Focus is on more-used API objects, it will take a few passes to drive these all the way down.
Also:
/src/pptx/lxmlwe use.