[wip] refactoring to match current scarpe wv #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gintama91
commented
Oct 10, 2023
| @@ -1,8 +1,8 @@ | |||
| source "https://rubygems.org" | |||
|
|
|||
| # Mandatory minimal gems for Scarpe-Wasm and for packaging | |||
| gem "scarpe-components", github: "scarpe-team/scarpe", glob: "scarpe-components/*.gemspec" | |||
| gem "lacci", github: "scarpe-team/scarpe", glob: "lacci/*.gemspec" | |||
| gem "scarpe-components", github: "scarpe-team/scarpe",branch:"main", glob: "scarpe-components/*.gemspec" | |||
There was a problem hiding this comment.
just some thought came to mind but i think it would be nice to have branches as releases? like branch: 2.0-stable or something ?
-- in scarpe-team/scarpe
There was a problem hiding this comment.
We'll eventually want release branches, yeah. Right now, scarpe-wasm is really not mature enough for that yet...
|
Nice! Yeah, this brings them into line much more closely :-) |
|
closing in favour of #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as noah seperated rendering logic , i thought it would be better if we refactor scarpe-wasm now , else if differences become more huge it makes it more hard in future to refactor things..