Progress #398
Merged
Progress #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
reviewed
Oct 5, 2023
lacci/lib/shoes/widgets/progress.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| module Shoes | ||
| class Progress < Shoes::Widget |
There was a problem hiding this comment.
Does it need a display property or something for % progress?
There was a problem hiding this comment.
yeah it does i guess there is value and max as two proerties and
i need to change this html into render method
so i made this into draft
There was a problem hiding this comment.
Ah, sorry, this says draft. So you're probably already on it. Looks like "fraction" is the Shoes style for it, and it's a float between 0.0 and 1.0.
|
|
|
Nice! Love the screenshot. |
noahgibbs
approved these changes
Oct 16, 2023
|
I think this was not merged due to conflicts? so meging now as i resolved them. |
|
Yay! 🎉 |
gintama91
added a commit
to gintama91/scarpe
that referenced
this pull request
Oct 19, 2023
* generating files is broken due to repo changes * progress * fraction * progress added fraction and refactored code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
progress
Image(if needed, helps for a faster review)
Checklist