Wrap rendered drawables in an outer div so it can be replaced or removed fully #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
html_wrapper_divs
branch
from
3f1af11 to
fe6193a
Compare
1 task
…ved fully. Don't do this for TextDrawables - they're tiny. Make Link and Span be TextDrawables, which they should have been anyway. Default needs_update to just updating the single drawable, not the whole tree. This is related to #419, but doesn't fully fix it.
noahgibbs
force-pushed
the
html_wrapper_divs
branch
from
fe6193a to
fa38e7f
Compare
Schwad
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the div makes it clear where the element ends, and lets us cleanly remove it. Right now the HTML ID may correspond to the outer div so you can easily replace it. But some elements (e.g. alerts) have never worked that way, and there's no requirement that any drawable render like that.
Checklist