Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for para margin #478

Closed
wants to merge 3 commits into from
Closed

Conversation

zoomzam
Copy link
Contributor

@zoomzam zoomzam commented Dec 5, 2023

Description

Add support for para margin

Checklist

  • Run tests locally

@noahgibbs
Copy link
Collaborator

I'm probably going to pull margin out of html_attributes, which doesn't really even work for what we're using it for, and put it in Drawable. We could pair on this if you'd like. But we don't really want to implement margin individually for each drawable, and it's actually supposed to work for basically all drawables.

@zoomzam
Copy link
Contributor Author

zoomzam commented Dec 5, 2023

okay, let's do it. Maybe a module to which every drawable can make a call. When do you have time for this?

@noahgibbs
Copy link
Collaborator

We'll probably want to wait until at least PR #473 is merged -- it touches some relevant stuff with initialize and styles. Once that's merged, I'm on UK time, but fairly free within that window. What time zone are you in?

@zoomzam
Copy link
Contributor Author

zoomzam commented Dec 6, 2023

GMT+5:30

@noahgibbs
Copy link
Collaborator

Okay. 473 is merged. I could be available tomorrow (Thurs) or Saturday if either of those works for you.

@zoomzam
Copy link
Contributor Author

zoomzam commented Dec 7, 2023

Saturday works!!

@noahgibbs
Copy link
Collaborator

Awesome. Let's plan on that. How does around 11am GMT work for you? So I assume that would be around 4:30pm in the afternoon.

@zoomzam
Copy link
Contributor Author

zoomzam commented Dec 7, 2023

sounds good

@noahgibbs
Copy link
Collaborator

Heya! It's around that time... Are you the same person as greenyblack in the Discord, or are you somebody else?

@noahgibbs
Copy link
Collaborator

I think we can close this now in favour of #489.

@zoomzam zoomzam closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants