-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for para margin #478
Conversation
I'm probably going to pull margin out of html_attributes, which doesn't really even work for what we're using it for, and put it in Drawable. We could pair on this if you'd like. But we don't really want to implement margin individually for each drawable, and it's actually supposed to work for basically all drawables. |
okay, let's do it. Maybe a module to which every drawable can make a call. When do you have time for this? |
We'll probably want to wait until at least PR #473 is merged -- it touches some relevant stuff with initialize and styles. Once that's merged, I'm on UK time, but fairly free within that window. What time zone are you in? |
GMT+5:30 |
Okay. 473 is merged. I could be available tomorrow (Thurs) or Saturday if either of those works for you. |
Saturday works!! |
Awesome. Let's plan on that. How does around 11am GMT work for you? So I assume that would be around 4:30pm in the afternoon. |
sounds good |
Heya! It's around that time... Are you the same person as greenyblack in the Discord, or are you somebody else? |
I think we can close this now in favour of #489. |
Description
Add support for para margin
Checklist