Improve Niente testing #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
niente_test_fixes
branch
from
694fd43 to
c7d337c
Compare
Also get Niente test log-printing under control
noahgibbs
force-pushed
the
niente_test_fixes
branch
from
c7d337c to
cb268fa
Compare
This was referenced Dec 14, 2023
Schwad
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Niente was ignoring Minitest results. D'oh! Fixed, and tests added to catch the problem in future.
Niente test printing should look more like other display services. That requires adding a min log level to the print logger, and using the regular print logger instead of Niente having a weird customised one.
Image(if needed, helps for a faster review)
Checklist