Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Para Styles #532

Closed
wants to merge 3 commits into from
Closed

Added new Para Styles #532

wants to merge 3 commits into from

Conversation

Nj221102
Copy link
Contributor

Description

Added some more para styles like font-variant, font
updated some para styles like font-family, emphasis

emphasis wasn't working before because it wasn't mentioned in shoes styles in lacci/lib/shoes/drawables/para.rb
font-family was mentioned as font in shoes styles so i changed it to family .

Shoes.app do
    
    para "this text is in normal styl" , emphasis:"italic"

    para "this text is in italic style" , font: "italic normal bold 16px/1.5 'Times New Roman', serif;"

    para "this text is in oblique style " , family: "'Pacifico', cursive;"

end
Shoes.app do

    para "This is Normal Variant" ,font_variant: "normal"


    para "This is Small Caps Variant " ,font_variant: "small-caps"

  end

Image(if needed, helps for a faster review)

Screenshot 2024-01-30 at 7 26 17 PM Screenshot 2024-01-30 at 7 27 17 PM

Checklist

  • Run tests locally

fixed tests

Fixed the error message

"Tests fixed"
@noahgibbs
Copy link
Collaborator

noahgibbs commented Jan 30, 2024

Mostly this is really good. But it does seem to break the existing font functionality. Example:

Shoes.app do
  para "Text in Helvetica", font: "Helvetica"

  para "And in Lucida", font: "Lucida"

  para "From an example", :font => "Trebuchet 20px bold"
end

I think we're going to need some kind of parsing of the "font" property in Lacci for this.

@Nj221102 Nj221102 mentioned this pull request Jan 30, 2024
1 task
@Nj221102
Copy link
Contributor Author

this branch got a little messed up, I have solved the issue and will make a separate PR after closing this one,
sorry if it causes inconvenience @noahgibbs

@Nj221102 Nj221102 closed this Jan 31, 2024
@noahgibbs
Copy link
Collaborator

All good, no trouble!

@Nj221102
Copy link
Contributor Author

All good, no trouble!

I have raised the new pull request #534 plz check it out.

@Nj221102 Nj221102 deleted the side branch February 1, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants