Updated Error Names #536
Merged
Updated Error Names #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
reviewed
Feb 1, 2024
lacci/lib/shoes/errors.rb
Outdated
|
|
||
| class BadLinkableIdError < Shoes::Error; end | ||
|
|
||
| class UnregisteredShoesEvent < Shoes::Error; end | ||
| class UnregisteredShoesError < Shoes::Error; end |
There was a problem hiding this comment.
In this case it's for an unregistered Shoes event. So we'd like to keep the word Event but add Error. Same for DoubleRegistered below.
There was a problem hiding this comment.
@noahgibbs is it good now? or need further changes
noahgibbs
approved these changes
Feb 1, 2024
|
Looks great! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made error names consistent
Checklist