-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit request for the source localization tutorial #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sampling rate is fractional it will crash spectopo because pwelch requires window and nfft to be integers. This can be fixed by rounding the sampling rate when defining winlength, however it might truncate data to exactly divide the length by the number of windows (see: https://www.mathworks.com/help/signal/ref/pwelch.html#shared-window)
spectopo: round winlength to nearest integer; fix #213
study: add hint to continuous dataset warning
Updated functions for compatibility with new ERPLAB datasets (for ERPLAB v10+)
ERPLAB menu vars updated
Hi Deepa, this is the EEGLAB code. For the tutorial please change this repo https://github.com/sccn/sccn.github.io |
Dear Arnaud,
Thank you for your kind guidance. I have corrected it now. Please let me
know if this is better now: sccn/sccn.github.io#88
Truly hope that's better now,
Thanking you,
Sincerely
Deepa Gupta <https://www.linkedin.com/in/deepaguptaresearcher/>
Postdoc Scholar, SCCN <https://sccn.ucsd.edu/>, SDSC <https://www.sdsc.edu/>
, INC <https://inc.ucsd.edu/index.php>, UCSD <https://ucsd.edu/>
Ph.D. , Dr. Choa's Lab <https://blogs.cs.umbc.edu/choalab/>, CSEE
<https://www.csee.umbc.edu/>, UMBC <https://www.umbc.edu/>
…On Wed, Jun 28, 2023 at 10:53 PM Arnaud Delorme ***@***.***> wrote:
Closed #643 <#643>.
—
Reply to this email directly, view it on GitHub
<#643 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFPLK3U35RQZL5WCQ4KLOTXNUJ6BANCNFSM6AAAAAAZXVOOLY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please note my comments below:
Suggestions for implementation:
1. Please consider adding somewhere that Fieldtrip-lite extension must be installed. If not, go to File-> manage EEGLAB extensions and install Fieldtrip-lite.
2. Please note that while executing the code for figure “5:ft_sourceplot: sourceProj”, I get the following error message:
could not reshape "time" to the dimensions of the volume Warning: functional data is complex, taking absolute value Check for incorrect argument data type or missing argument in call to function 'abs'. Error in ft_sourceplot (line 455) fun = abs(fun); Error in dipfit_example_tutorialtest20230823 (line 89) figure; ft_sourceplot(cfg, sourceProj);
3. Please note that while executing the code for the section:
%% Prepare leadfield surface
In the section ‘Performing source reconstruction:’
I get the warning:
Warning: adding C:\Users\d2gupta\Documents\eeglab2022.1\plugins\Fieldtrip-lite20230613\external\gifti toolbox to your MATLAB path Warning: use cfg.sourcemodel instead of cfg.grid
Cosmetic changes’ suggestions to descriptive for clarity to the reader:
1. Please consider changing the heading from "Equivalent dipole source localization of EEG data" to "Equivalent dipole source localization of EEG or ERP data"
2. Positive affirmation first: Please consider changing first line to "EEGLAB provides a command-line implementation of the DIPFIT plugin to fit dipoles to raw ERP or EEG scalp maps that has otherwise not been expressly designed anywhere else including the plugin itself" from "Though the implementation of the DIPFIT plugin has not been expressly designed to fit dipoles to raw ERP or EEG scalp maps, EEGLAB provides a command-line function allowing DIPFIT to do so. "
3. For giving the beginner an idea about what is DIPFIT as a starter, please consider hyperlinking DIPFIT plugin in the first line to: https://github.com/sccn/dipfit AND https://sccn.ucsd.edu/eeglab/dipfittut/dipfit.htmlold AND https://eeglab.org/tutorials/09_source/DIPFIT.html
4. Please correct this: The “here” in “Click here to download the script above” is leading to an error message “Notice: Undefined variable: baseurl2 in /var/local/www/html/eeglab/locatefile.php on line 80 File not found”.
5. Please include the eeglab_data_epochs_ica.set file or the instructions for how to fetch this sample dataset.
6. In the section “Advanced source reconstruction using DIPFIT/Fieldtrip”:
a. please make a subsection “History” or “Background” and then in that include the first paragrpah “DIPFIT relies on Fieldtrip, though in fact, DIPFIT was also an ancestor of Fieldtrip: when Robert Oostenveld, the first Fieldtrip developer, decided to release source imaging functions he had developed during his dissertation work, he first packaged them in EEGLAB as DIPFIT. A few years later, when he and his collaborators released Fieldtrip (also running on MATLAB), we reworked DIPFIT so it would use the Fieldtrip functions that Robert and colleagues planned to and have since maintained for use in Fieldtrip. Below is a short tutorial on how to perform source modeling using Fieldtrip applied to data in an EEGLAB dataset.”
b. Also, one may consider hyperlinking here DIPFIT to the earlier links as highlighted in the above point#3 in this first paragraph of history.
c. Subsection “Implementation” or “Performing source reconstruction in a volume” could include text from “First, use DIPFIT to align the electrode locations with a head model of choice (menu item Tools → Locate dipoles using DIPFIT → Head model and settings). The resulting DIPFIT information … and so on”
7. Please correct this: script download link in the section ‘Performing source reconstruction on a surface’ is giving the error: “Notice: Undefined variable: baseurl2 in /var/local/www/html/eeglab/locatefile.php on line 80 File not found”
8. Please consider perhaps specifying the following tutorial additionally in the relevant section: https://eeglab.org/tutorials/09_source/Model_Settings.html and https://eeglab.org/tutorials/09_source/Custom_head_model.html
I hope the above is helpful
Thanking you
Sincerely
Deepa Gupta