-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kotlinesque #548
Open
elect86
wants to merge
1
commit into
main
Choose a base branch
from
feature/kotlinesque
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/kotlinesque #548
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package graphics.scenery | ||
|
||
inline operator fun <M : Mesh> M.invoke(init: M.() -> Unit): M { | ||
apply(init) | ||
return this | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,60 +19,56 @@ class ArcballExample : SceneryBase("ArcballExample") { | |
override fun init() { | ||
renderer = hub.add(Renderer.createRenderer(hub, applicationName, scene, 1024, 1024)) | ||
|
||
val cam: Camera = DetachedHeadCamera() | ||
with(cam) { | ||
val cam: Camera = DetachedHeadCamera { | ||
spatial { | ||
position = Vector3f(0.0f, 0.0f, 2.5f) | ||
} | ||
perspectiveCamera(70.0f, windowWidth, windowHeight) | ||
|
||
targeted = true | ||
target = Vector3f(0.0f, 0.0f, 0.0f) | ||
|
||
scene.addChild(this) | ||
} | ||
scene += cam | ||
|
||
val camlight = PointLight(3.0f) | ||
camlight.intensity = 5.0f | ||
cam.addChild(camlight) | ||
|
||
val box = Box(Vector3f(1.0f, 1.0f, 1.0f)) | ||
val camlight = PointLight(3.0f) { | ||
intensity = 5.0f | ||
} | ||
cam += camlight | ||
|
||
with(box) { | ||
val box = Box(Vector3f(1.0f, 1.0f, 1.0f)) { | ||
spatial { | ||
position = Vector3f(0.0f, 0.0f, 0.0f) | ||
} | ||
material { | ||
ambient = Vector3f(1.0f, 0.0f, 0.0f) | ||
diffuse = Vector3f(0.0f, 1.0f, 0.0f) | ||
textures["diffuse"] = Texture.fromImage(Image.fromResource("textures/helix.png", TexturedCubeExample::class.java)) | ||
textures["diffuse"] = Image.fromResource<TexturedCubeExample>("textures/helix.png").toTexture() | ||
specular = Vector3f(1.0f, 1.0f, 1.0f) | ||
} | ||
|
||
scene.addChild(this) | ||
} | ||
scene += box | ||
|
||
val lights = (0..2).map { | ||
PointLight(radius = 15.0f) | ||
}.map { light -> | ||
light.spatial { | ||
position = Random.random3DVectorFromRange(-3.0f, 3.0f) | ||
val lights = List(3) { | ||
PointLight(radius = 15.0f) { | ||
spatial { | ||
position = Random.random3DVectorFromRange(-3.0f, 3.0f) | ||
} | ||
emissionColor = Random.random3DVectorFromRange(0.2f, 0.8f) | ||
intensity = Random.randomFromRange(0.1f, 0.8f) | ||
} | ||
light.emissionColor = Random.random3DVectorFromRange(0.2f, 0.8f) | ||
light.intensity = Random.randomFromRange(0.1f, 0.8f) | ||
light | ||
} | ||
|
||
val floor = Box(Vector3f(500.0f, 0.05f, 500.0f)) | ||
floor.spatial { | ||
position = Vector3f(0.0f, -1.0f, 0.0f) | ||
} | ||
floor.material { | ||
diffuse = Vector3f(1.0f, 1.0f, 1.0f) | ||
val floor = Box(Vector3f(500.0f, 0.05f, 500.0f)) { | ||
spatial { | ||
position = Vector3f(0.0f, -1.0f, 0.0f) | ||
} | ||
material { | ||
diffuse = Vector3f(1.0f, 1.0f, 1.0f) | ||
} | ||
} | ||
scene.addChild(floor) | ||
scene += floor | ||
|
||
lights.forEach(scene::addChild) | ||
scene += lights | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assuming the |
||
} | ||
|
||
override fun inputSetup() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a neat trick. But I find it odd to override
plusAssign
but notplus
. The implication, which is not true for these types, is thatcam + camlight
would be a new camera object with the light added, and only because the+=
was used does it get assigned back into the samecam
variable. Is this a pattern Kotlin users often use for mutators, to override only the+=
but not+
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I guess it's convenient, so I'll swallow my feelings of mathematical discomfort 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might say this is one of the example on the border line, some people will assume this to be an operator abuse, others don't
But that's where I like to give the choice :)