Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenVRHMD safe shutdown #788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OpenVRHMD safe shutdown #788

wants to merge 1 commit into from

Conversation

smlpt
Copy link
Contributor

@smlpt smlpt commented Nov 18, 2024 •
edited
Loading

This PR adds initalized = false to OpenVRHMD.close() before calling the shutdown logic to prevent the renderer from accessing memory that doesn't exist anymore.

@smlpt smlpt added the bugfix PR contains a bugfix label Nov 18, 2024
@skalarproduktraum
Copy link
Member

@smlpt While you are at it, would you be so kind to check the other functions in OpenVRHMD as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skalarproduktraum skalarproduktraum Awaiting requested review from skalarproduktraum

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix PR contains a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smlpt @skalarproduktraum