Openmeteo correction for daily astronomy. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current openweather api usage does not have daily astronomy. Api "onecall" seems to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current openweather api usage does not have daily astronomy. Api "onecall" seems to have.
Openmeteo has daily astronomy
Motivation and Context
When requesting the output as json, daily astronomy data was not set correctly (only one day)
Description
Since Openmeteo has daily astronomy I have corrected the forecast data for each day.
Steps for Testing
Execute with frontend flag set for json ( -f json ). Each day should have sunrise and sunset correctly set.
Screenshots