Likes #61
Open
Likes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but these circular imports create two instances of 'media_server' (one as '__main__' and one as 'media_server' which eventually mesh with the db. Therefore we activate this script via the flask commands/.flaskenv and not directly (Unstaged and untracked files will be added in the next commit for clarity)
…ith videos' filenames. This should be useful for implementing the comments because these can be stored also in the db and just like the two models (video and comment). Like/dislike buttons are sending an asynchronous request (via jquery/ajax) in flask/media_server.py with a corresponding string indicating like or dislike. Flask receives them and updates the database num of likes (row) for the current video (column). The video object stored in the database is stored in models.py. Other objects to be stored in the db could be added there too (don't forget to apply db migrations when making changes in the models). Because the both media_server.py and models.py need a reference to the db -which is initialized within media_server.py- we create it in globalimports.py which we later import everwhere else to avoid circularity of SQLAlchemy's imports. New dependencies where needed (flask-sqlalchemy, flask-migrate) which are listed in requirements.py. Further improvments: -limit even more the requests to the db by not commiting on every like incement/decrement -add an likes counter inside the video page -style buttons
|
Hey, thanks for the PR, I'll review it soon! In the meantime, is it possible that you can provide a deployed version of your PR on something like Netlify? If not, no problem, I'll clone and try it out soon. |
|
I'm afraid I'm not familiar with netlify so I'll leave that up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be useful for implementing the comments because these can be stored also in the db and just like the two models (video and comment).
Like/dislike buttons are sending an asynchronous request (via jquery/ajax) in flask/media_server.py with a corresponding string indicating like or dislike. Flask receives them and updates the database num of likes (row) for the current video (column).
The video object stored in the database is stored in models.py. Other objects to be stored in the db could be added there too (don't forget to apply db migrations when making changes in the models).
Because the both media_server.py and models.py need a reference to the db -which is initialized within media_server.py- we create it in globalimports.py which we later import everywhere else to avoid circularity of SQLAlchemy's imports.
New dependencies where needed (flask-sqlalchemy, flask-migrate) which are listed in requirements.py.
Further improvements:
-limit even more the requests to the db by not committing on every like increment/decrement
-add an likes counter inside the video page
-style buttons