Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe: type function #47

Merged
merged 2 commits into from
Aug 18, 2021
Merged

recipe: type function #47

merged 2 commits into from
Aug 18, 2021

Conversation

jcubic
Copy link
Contributor

@jcubic jcubic commented Aug 16, 2021

New recipe. There is a missing bytevector?, but it was not working in Chicken and Guile out of the box.

Copy link
Member

@lassik lassik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This PR is related to Issue #46)

(else "unknown-port")))
((eof-object? obj) "eof")
((char? obj) "character")
((boolean? obj) "boolean")))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could return symbols instead of strings? Common Lisp uses symbols to name types, and if we made a type system for Scheme, it would most likely use symbols too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@jcubic
Copy link
Contributor Author

jcubic commented Aug 18, 2021

Using @lassik code from #46 discussion.

@lassik
Copy link
Member

lassik commented Aug 18, 2021

Thanks!

@lassik lassik merged commit 1e7869a into master Aug 18, 2021
@lassik lassik deleted the type branch August 18, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants