add support for multiple service annotations #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wodka
force-pushed
the
service-multiple
branch
from
4ea63dc to
0f4d87a
Compare
|
perhaps something like: Ideas? |
| */ | ||
| public function addService(array $service) | ||
| { | ||
| if (empty($this->id)) { |
There was a problem hiding this comment.
IMO we should deprecate all this attributes
There was a problem hiding this comment.
I added the deprecated annotation to old properties
wodka
force-pushed
the
service-multiple
branch
from
6d4a192 to
4533b8a
Compare
| /** | ||
| * get list of defined services, use fallback of original fields | ||
| * | ||
| * return array[] |
wodka
force-pushed
the
service-multiple
branch
4 times, most recently
from
5275158 to
6379051
Compare
add deprecation warnings add services support to AfterSetup add tests fix schmittjoh#232
wodka
force-pushed
the
service-multiple
branch
from
6379051 to
7655431
Compare
|
@Ener-Getick I just added the support for AfterSetup services |
| ); | ||
| } | ||
| foreach ($classMetadata->getServices() as $service) { | ||
| if (isset($environment) |
There was a problem hiding this comment.
Use null !== instead, it is clearer
|
I'm wondering if we should not create a new |
|
@schmittjoh What do you think about having a new metadata class ? something like |
|
as this is a big stuff, I think it will wait for 1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this only adds the ability to define multipe service annotations on a class
to fully implement #232 we need to define how to add injections based on different service notations.