Honor bundles configuration in controller injectors warmer #270
Conversation
|
ping @GuilhemN please review |
|
Sorry I won't have the time to review this. Please do and if you approve it, I'll merge it. |
| KernelInterface $kernel, | ||
| ControllerResolver $resolver, | ||
| array $blackListedControllerFiles, | ||
| $scanAllBundles, |
There was a problem hiding this comment.
Should be optional and default to true
| ControllerResolver $resolver, | ||
| array $blackListedControllerFiles, | ||
| $scanAllBundles, | ||
| array $scanBundles |
There was a problem hiding this comment.
Should be optional and default to array(). That way, the constructor is still callable like it was before.
There was a problem hiding this comment.
I'm going to push the changes. Out of curiosity, why provinding default values just to make the constructor callable like before? Service is created and managed by Symfony DI, so why bother?
There was a problem hiding this comment.
Because who knows who might use it without sf DI?
|
LGTM @GuilhemN |
|
Travis failed 😢 |
|
@OskarStark it failed before and is apparently not a blocker. |
|
Is there something I can do to get this merged? |
|
Pray your god and/or @GuilhemN |
Yes, we have to fix them but i'm lacking time...
Ahah 😄 I'd be glad to you as collaborator since I can't put much time in this repository but unfortunately I don't have the admin rights 😕 |
|
@GuilhemN can you create a release? |
|
I don't know much about this bundle or even use it, but that should not stop me from providing some help if you so desperately need it :) I'll try to have a look at pending PRs |
|
Please don't tag yet, this seems to be buggy: #287 |
I'm in a french "prépa" since the beginning of the month so I'm really running out of time 😄 thanks for taking care of this bundle, but of course don't feel forced to do anything ☺ @schmittjoh could you add @greg0ire as collaborator please? |
I went through that myself! See you in 2 / 3 years then I guess :P |
This should solve #269 and #248.