Fix controller injections when there are no dirs to scan #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adaniloff @mzampetakis please review |
greg0ire
suggested changes
Sep 28, 2017
| require_once $filename; | ||
| // Combination of scanAllBundles/scanBundles can lead to empty dirs. | ||
| // Only search for controllers if we have at least one directory, | ||
| // otherwise the finder will throw an exception. |
There was a problem hiding this comment.
Please use multiline syntax (/*) for multiline comments
There was a problem hiding this comment.
Are you sure? There is a comment a few lines below and I used the same style...
There was a problem hiding this comment.
Oh ok forget it then I guess :P
greg0ire
approved these changes
Sep 28, 2017
adaniloff
approved these changes
Sep 28, 2017
|
@gremo The PR works fine in my case ! |
|
@GuilhemN , this looks RTM |
|
Thank you guys for taking care of this ☺ |
|
Thanks @GuilhemN , can you tag a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #287.
With empty configuration or when the combination of
all_bundlesandbundlesoptions led up to empty folders in controller injector warmer, the finder component throws an exception.Offending commit 55c3f87