[WIP] Compatibility with Symfony 3.4 #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created this WIP because I wanted to trigger running Travis. |
|
Thanks for the PR, the latest version now supports 3.4 and 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
symfony4removes the dependency ondi-extra-bundle. As many projects are still in the progress of upgrading3.4to4.0, still supporting3.4for now would be welcome. After comparingsymfony4tomasterit seems that no Symfony 4 specific features are used so far.References
symfony/symfony#27053
schmittjoh/JMSDiExtraBundle#282