web: Register PWA reload script earlier

schneefux · Dec 22, 2024 · 8d423f7 · 8d423f7
1 parent 20b8323
commit 8d423f7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/web/renderer/+onRenderClient.ts b/web/renderer/+onRenderClient.ts
@@ -14,11 +14,6 @@ export { onRenderClient }
 async function onRenderClient(pageContext: PageContext) {
   const params = createApp(pageContext)
 
-  initSentry(pageContext.envConfig.sentryDsn, params.app, params.router)
-  hydrate(params.queryClient, pageContext.vueQueryState)
-  params.pinia.state.value = SuperJSON.parse(pageContext.piniaState)
-  await params.router.isReady()
-
   const { registerSW } = await import('virtual:pwa-register') // use dynamic import to fetch sw at runtime
   registerSW({
     immediate: true, // reload app when service worker updates
@@ -29,5 +24,12 @@ async function onRenderClient(pageContext: PageContext) {
       })
     },
   })
+
+  initSentry(pageContext.envConfig.sentryDsn, params.app, params.router)
+  hydrate(params.queryClient, pageContext.vueQueryState)
+  params.pinia.state.value = SuperJSON.parse(pageContext.piniaState)
+
+  await params.router.isReady()
+
   params.app.mount('#app')
 }
diff --git a/web/renderer/app.ts b/web/renderer/app.ts
@@ -71,7 +71,7 @@ function createApp(pageContext: PageContext) {
       },
     ],
     link: [
-      { rel: 'manifest', href: '/manifest.webmanifest' },
+      { rel: 'manifest', href: '/manifest.webmanifest' }, // TODO try https://vite-pwa-org.netlify.app/frameworks/#accessing-pwa-info instead
       { rel: 'icon', href: '/icons/favicon.ico', sizes: 'any' },
       { rel: 'icon', href: '/icons/favicon.svg', type: 'image/svg+xml' },
       { rel: 'apple-touch-icon', href: '/icons/icon_x512.png', sizes: '512x512' },

diff --git a/web/vite.config.ts b/web/vite.config.ts
@@ -41,7 +41,7 @@ const config: UserConfig = {
       resolver: 'vue',
     }),
     VitePWA({
-      injectRegister: null, // not supported by vike, injected in all.page.client instead
+      injectRegister: null, // not supported by vike, injected in +onRenderClient.ts instead
       registerType: 'autoUpdate',
       devOptions: {
         enabled: false,