Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator limit #331

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Generator limit #331

merged 4 commits into from
Jul 12, 2024

Commits on Jul 7, 2024

  1. align functions add_cidr() and add_range()

    * call freeaddrinfo() before checking the prefix length in
      add_cidr()
    * add a comment to the generator limit check in add_range()
    auerswal committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    83e61a0 View commit details
    Browse the repository at this point in the history
  2. also apply generator limit to use with CIDR

    As described in GH issue schweikert#299, the MAX_GENERATE+1 limit is only
    applied when using an address range, not when using CIDR.  This
    commit changes this to always honor the generator limit.
    
    * refactor target address generation to use the same new function
      for both range and CIDR notation
    * check the limit for addresses to generate in the new function
    * document the generator limit in "fping --help" output
    * document the generator limit in the fping man page
    * test that the address generation limit applies when using CIDR
      notation
    auerswal committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    2303ccc View commit details
    Browse the repository at this point in the history
  3. fix off-by-one error in generator limit

    This commit does not add tests that verify the exact limit,
    because pinging 100000 localhost addresses takes over 15
    minutes on my PC.  I have tested this fix manually.
    auerswal committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    ce5d896 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6a6077 View commit details
    Browse the repository at this point in the history