Skip to content

Start writing docs. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Dec 3, 2024

Hi @lagru,

Here I'm starting some minimal documentation as per #9.

I'm using the same structure and formats as scikit-image's so we can use the same machinery to build the docs, i.e., generated the rendered HTML pages. I guess we should deploy these somewhere?

I've noticed that

Maybe it would be more consistent to have doc/src/index.rst instead of doc/source/index.rst?

@lagru lagru mentioned this pull request Dec 4, 2024
28 tasks
@lagru lagru added the documentation Improvements or additions to documentation label Dec 4, 2024
@lagru
Copy link
Member

lagru commented Dec 4, 2024

Thanks for getting this going @mkcor!

I've been thinking about how to keep the effort for the documentation infrastructure low during early development. E.g. start with a Wiki on the Repo? I'm also considering to go "full markdown" for docstubs documentation via MyST?

I'm curious what you think.

Maybe it would be more consistent to have doc/src/index.rst instead of doc/source/index.rst?

I've never really been a fan of the extra doc/source/ folder / level in scikit-image and would love to avoid it here if we can.

@mkcor
Copy link
Member Author

mkcor commented Dec 9, 2024

Hi @lagru!

I've never really been a fan of the extra doc/source/ folder / level in scikit-image and would love to avoid it here if we can.

I totally agree, doc/index.rst should be good enough!

I've been thinking about how to keep the effort for the documentation infrastructure low during early development. E.g. start with a Wiki on the Repo? I'm also considering to go "full markdown" for docstubs documentation via MyST?

Nice, I like being minimalist. Good idea; let's keep the docs in the repo's wiki, at least for now. We can always move them later, and they'll be in Markdown already.

PS: I found out about MyST last year at JupyterCon and would love a pretext to try it out!

@mkcor
Copy link
Member Author

mkcor commented Dec 9, 2024

@lagru would you mind creating the wiki for this repo? I personally don't have access to the 'Settings' tab... I guess that's where you can check the box to get the Wiki. Thanks!

@mkcor
Copy link
Member Author

mkcor commented Jan 4, 2025

would you mind creating the wiki for this repo?

Or, alternatively, give me permission to do so? Any update on this, @lagru? Thanks.

@lagru
Copy link
Member

lagru commented Jan 5, 2025

Oh, I didn't realize that you needed write permissions. I granted you those, but maybe its easiest to just commit the markdown files in the main repo instead of taking the detour via wiki. We can worry about the plumbing for a HTML documentation later.

That way your contributions are more visible also, stay preserved and we have a proper review process. :)

@mkcor
Copy link
Member Author

mkcor commented Jan 7, 2025

maybe its easiest to just commit the markdown files in the main repo

You're right.

That way your contributions are more visible also, stay preserved and we have a proper review process. :)

Very valid point! Good, I'll update this PR then, and mark it as ready for review.

@mkcor mkcor marked this pull request as ready for review January 14, 2025 16:24
@mkcor
Copy link
Member Author

mkcor commented Jan 14, 2025

@lagru the action is happening at 699c509 :shipit:

@@ -0,0 +1,71 @@
# docstub user guide

**Version**:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to insert a variable in here...

@@ -0,0 +1,71 @@
# docstub user guide

**Version**:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to insert a variable in here...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, we could hard-write it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think we can skip this for now. It should be pretty clear that the user guide reflects the current version of the repo. Longterm this should end up in a website with a version switcher anyway. :)

@mkcor mkcor requested a review from lagru February 18, 2025 21:47
Co-authored-by: Marianne Corvellec <[email protected]>
@lagru
Copy link
Member

lagru commented Mar 12, 2025

@mkcor, do you mind if I go through this PR and tweak and update as you go? I think that might be the fastest approach to fleshing out this guide some more. After that we can have another round of iteration. I'd be especially thankful for your eyes which are less familiar with the inner workings!

@lagru lagru removed their request for review March 12, 2025 13:01
@mkcor
Copy link
Member Author

mkcor commented Mar 12, 2025

I don't mind at all, please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants